[Asterisk-code-review] tests/test http media cache: Add unit tests for res http med... (asterisk[master])

[Badalian Vyacheslav]

Badalian Vyacheslav has posted comments on this change.

Change subject: tests/test_http_media_cache: Add unit tests for res_http_media_cache
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.asterisk.org/#/c/1891/3/tests/test_http_media_cache.c
File tests/test_http_media_cache.c:

Line 100: error
and free don't allocated buffer....


Line 120: open
No so many chances to close it


Line 187: return
free http_header?

Looks like mistake... all vars in 'error case' is cleard but here is not.

its look like buffers... why not presized buffer or stack allocation?


-- 
To view, visit https://gerrit.asterisk.org/1891
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2db101e307c863857fe416d6f5bf4cace9ac7cf5
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Badalian Vyacheslav <slavon.net at gmail.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes