[Asterisk-code-review] Stasis: Use control queue to prevent crash. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Stasis: Use control queue to prevent crash.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/2056/2/res/stasis/control.c
File res/stasis/control.c:

Line 375: 	if (stasis_app_send_command_async(control, app_control_add_role, role_dup, ast_free_ptr)) {
        : 		ast_free(role_dup);
        : 		return -1;
        : 	}
> I think this has the potential of a "double free". If you follow the code a
Yep, I see what you're saying. In the interest of not mixing too many things together, I'm going to revert this back to patchset 1, and I'm going to submit the memory leak fix as a separate review request.


-- 
To view, visit https://gerrit.asterisk.org/2056
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a0a4d51bce6fba6f1d9954e40935e42f366ea78
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes