[Asterisk-code-review] Stasis: Use control queue to prevent crash. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: Stasis: Use control queue to prevent crash.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2056/1/res/stasis/control.c
File res/stasis/control.c:

Line 375: 	stasis_app_send_command_async(control, app_control_add_role, role_dup, ast_free_ptr);
If this call fails it looks like role_dup could be leaked.


Line 644: 	stasis_app_send_command_async(control, app_control_set_channel_var, var, ast_free_ptr);
Same here, depending on why the call to stasis_app_send_command_async fails this may leak 'var'


-- 
To view, visit https://gerrit.asterisk.org/2056
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a0a4d51bce6fba6f1d9954e40935e42f366ea78
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes