[Asterisk-code-review] main/asterisk.c: ast el read char (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: main/asterisk.c: ast_el_read_char
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/2032/3/main/asterisk.c
File main/asterisk.c:

Line 2705: 				if (write(STDOUT_FILENO, "\r", 5) < 0) {
> bit of an ugly method of doing that, but ok (i guess). We could start by ad
If we don't care about the return of write but want to suppress any unused return warning couldn't we just use:
(void)write(STDOUT_FILENO, "\r[0K", 5);


-- 
To view, visit https://gerrit.asterisk.org/2032
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcd7f691310815a31756b76067c56fba299d3ae9
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes