[Asterisk-code-review] Stasis: Prevent operations on hung-up channels. (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: Stasis: Prevent operations on hung-up channels.
......................................................................


Patch Set 1: Code-Review-1

So looking beyond this fix (which would indeed fix the problem) - are we using the control queue in the right way in all cases? Looking at the implementation we should be using the command mechanism, which would ensure that the channel would be alive and things are as expected. I think the correct fix would be ensuring the set variable case does this. It will also be useful to do a further audit to see if there's any other cases, and perhaps document this (I can't find anything relevant).

-- 
To view, visit https://gerrit.asterisk.org/2053
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3b114e6019a3ab9337098039a2a114f7accebb52
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No