[Asterisk-code-review] res odbc: Remove connection management (asterisk[13])

Joshua Colp asteriskteam at digium.com
Wed Jan 20 12:12:07 CST 2016


Joshua Colp has posted comments on this change.

Change subject: res_odbc: Remove connection management
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Minor nitpick.

https://gerrit.asterisk.org/#/c/2005/1/res/res_odbc.c
File res/res_odbc.c:

Line 719: 	obj = ao2_alloc(sizeof(*obj), odbc_obj_destructor);
Need to check for allocation failure here.


https://gerrit.asterisk.org/#/c/2005/1/res/res_odbc_transaction.c
File res/res_odbc_transaction.c:

Line 207: 	
You need some visine for this redness.


-- 
To view, visit https://gerrit.asterisk.org/2005
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37a84def5ea4ddf93868ce8105f39de078297fbf
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list