[Asterisk-code-review] Refactor init logger chain locking. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Tue Jan 19 13:19:01 CST 2016


Richard Mudgett has posted comments on this change.

Change subject: Refactor init_logger_chain locking.
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Minor nit

https://gerrit.asterisk.org/#/c/2043/1/main/logger.c
File main/logger.c:

Line 562: /* \brief Read config, setup channels.
        :  * \param locked The logchannels list is locked and this is a reload
        :  * \param altconf Alternate configuration file to read.
        :  *
        :  * \retval 0 Success
        :  * \retval -1 No config found or Failed
        :  */
        : static int init_logger_chain(const char *altconf)
Add doxygen note that logchannels needs to be write locked before calling.


-- 
To view, visit https://gerrit.asterisk.org/2043
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc42117338bf9575650a67bcb78ab1a33d7bad8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list