[Asterisk-code-review] funcs/func cdr: Correctly report high precision values for d... (asterisk[master])

Mark Michelson asteriskteam at digium.com
Tue Jan 19 10:26:27 CST 2016


Mark Michelson has posted comments on this change.

Change subject: funcs/func_cdr: Correctly report high precision values for duration and billsec
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2044/1/funcs/func_cdr.c
File funcs/func_cdr.c:

Line 233: 		ast_copy_string(tempbuf, value, sizeof(tempbuf));
I don't think this ast_copy_string() call is necessary. tempbuf should have already been filled with the value by ast_cdr_format_var().


-- 
To view, visit https://gerrit.asterisk.org/2044
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bc63822b496537a5bf80baf6102c06206bee841
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list