[Asterisk-code-review] bridge basic: don't cache xferfailsound during an attended t... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: bridge_basic: don't cache xferfailsound during an attended transfer
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

Minor nits that you don't have to fix.

https://gerrit.asterisk.org/#/c/2014/3/main/bridge_basic.c
File main/bridge_basic.c:

Line 1423: 		ast_log(LOG_ERROR, "Unable to create props - channel %s, context %s\n",
This isn't necessary as ao2_alloc has already griped about memory allocation failure.


Line 1431: 		ast_log(LOG_ERROR, "Unable to initialize prop fields - channel %s, context %s\n",
Same here


-- 
To view, visit https://gerrit.asterisk.org/2014
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic726b0f54ef588bd9c9c67f4b0e4d787934f85e4
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes