[Asterisk-code-review] bridge basic: don't cache xferfailsound during an attended t... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: bridge_basic: don't cache xferfailsound during an attended transfer
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2014/2/include/asterisk/features_config.h
File include/asterisk/features_config.h:

Line 107:  * \note The channel should be locked before calling this function.
Everywhere this function is called the chan is not locked.  Nor can the channel be locked as you are then going to play a sound file which takes awhile.  You should lock chan inside this function and remove this restriction instead.


https://gerrit.asterisk.org/#/c/2014/2/main/bridge_basic.c
File main/bridge_basic.c:

Line 1422: 	if (!props || ast_string_field_init(props, 64)) {
         : 		return NULL;
props is leaked here if fail to init stringfields.

This is a pre-existing bug.

Another question is can ast_cond_destroy() be called in the destructor if ast_cond_init() hasn't been done yet because stringfields failed to initialize here?


-- 
To view, visit https://gerrit.asterisk.org/2014
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic726b0f54ef588bd9c9c67f4b0e4d787934f85e4
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes