[Asterisk-code-review] res pjsip/config system: Add ast sip get pjproject buildopt (asterisk[master])

George Joseph asteriskteam at digium.com
Fri Jan 15 14:04:31 CST 2016


Hello Richard Mudgett, Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2013

to look at the new patch set (#3).

Change subject: res_pjsip/config_system:  Add ast_sip_get_pjproject_buildopt
......................................................................

res_pjsip/config_system:  Add ast_sip_get_pjproject_buildopt

As a follow-on to the recent 'Add CLI "pjsip show buildopts"' patch,
a new ast_sip_get_pjproject_buildopt function has been added.  It
allows the caller to get the value of one of the buildopts.

The initial use case is retrieving the runtime value of
PJ_MAX_HOSTNAME to insure we don't send a hostname greater
than pjproject can handle.  Since it can differ between
the version of pjproject that Asterisk was compiled against
and the version of pjproject that Asterisk is running against,
we can't use the PJ_MAX_HOSTNAME macro directly in Asterisk
source code.

res_pjsip_log_forwarder was also refactored to move some
functionality to config_system where it can be used before
res_pjsip starts loading sorcery.

Change-Id: Icd23c289e1190edf9c6f07cabf382144ccef5b31
---
M include/asterisk/res_pjsip.h
M res/res_pjsip/config_system.c
M res/res_pjsip_log_forwarder.c
3 files changed, 173 insertions(+), 79 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/13/2013/3
-- 
To view, visit https://gerrit.asterisk.org/2013
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd23c289e1190edf9c6f07cabf382144ccef5b31
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list