[Asterisk-code-review] res pjsip log forwarder: Add ast sip get pjproject buildopt (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_log_forwarder:  Add ast_sip_get_pjproject_buildopt
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2012/2/res/res_pjsip_log_forwarder.c
File res/res_pjsip_log_forwarder.c:

Line 140: int ast_sip_get_pjproject_buildopt(char *option, char *format_string, ...)
This function now makes res_pjsip_log_forwarder.c a global symbol exporter.  This scheme is going to cause linking issues.  Maybe you should change it so that when this module loads it gets the PJ_MAX_HOSTNAME value and passes it up to res_pjsip.  Until this module loads res_pjsip will use the default 128 value.


-- 
To view, visit https://gerrit.asterisk.org/2012
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd23c289e1190edf9c6f07cabf382144ccef5b31
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes