[Asterisk-code-review] RFC: Add global pluggable modules. (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: RFC: Add global pluggable modules.
......................................................................


Patch Set 4:

This latest revision is pretty wildly different from previous ones. There now is no runtime option for runtests.py (in fact, runtests.py is no longer even altered by this commit). Instead, there is a more general concept of global pluggable modules used here instead. By having the realtime conversion module loaded globally, it will be loaded on all tests being run.

Currently, there is no "opt-in" mechanism. What I figure we can do is to make use of the tag system we already have. Test agents that use the realtime conversion pluggable module could also specify a certain tag to use when running tests. A later commit can add this tag to all tests where we want automatic realtime conversion.

To clear the air a bit, I for some reason misunderstood your previous suggestion about a "setup_realtime" function. I thought you were suggesting replacing the pluggable module with that rather than simply adding it to the pluggable module. As it stands, I still have not added such a thing because I don't think it's really going to be necessary any longer. Instead, the general nature of the global pluggable module means that there are no hard-coded changes throughout any of the test library.

-- 
To view, visit https://gerrit.asterisk.org/1803
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec1b1cfa48cadab108c4ab65122ce36ab697e4e
Gerrit-PatchSet: 4
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: No