[Asterisk-code-review] Sorcery: Create human friendly serializer names. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Sorcery: Create human friendly serializer names.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1957/2/main/sorcery.c
File main/sorcery.c:

Line 860: 	ast_taskprocessor_build_name(tps_name, sizeof(tps_name), "sorcery/%s", type);
> Include the module name in here in case we ever have a case with two module
Including the module name results in names that are way too long which get truncated.

Putting the module name first to get a better sort like this (sorcery/<module>/<type>) results in the type often getting partially or completely truncated for modules like "res_pjsip_outbound_registration".  Putting the module name second like this (sorcery/<type>/<module>) is better because the type name is usually there but the module name gets truncated and the sort is not as helpful.

sorcery/acl/res_pjsip_acl-00000027                     0          0          0                                                                                                                                 
sorcery/aor/res_pjsip-00000015                         1          0          1                                                                                                                                 
sorcery/asterisk-publication/res_pjs-00000021          0          0          0                                                                                                                                 
sorcery/auth/res_pjsip-00000010                        0          0          0                                                                                                                                 
sorcery/bucket/core-00000000                           0          0          0                                                                                                                                 
sorcery/contact/res_pjsip-00000014                     1          0          1                                                                                                                                 
sorcery/contact_status/res_pjsip-00000016              1          0          1                                                                                                                                 
sorcery/domain_alias/res_pjsip-00000017                0          0          0
sorcery/endpoint/res_pjsip-00000011                    1          0          1                                                                                                                                 
sorcery/file/core-00000001                             0          0          0                                                                                                                                 
sorcery/global/res_pjsip-00000018                      1          0          1                                                                                                                                 
sorcery/identify/res_pjsip_endpoint_-00000025          0          0          0
sorcery/inbound-publication/res_pjsi-0000001d          0          0          0
sorcery/mailboxes/res_mwi_external-00000019            0          0          0
sorcery/nat_hook/res_pjsip-00000012                    0          0          0
sorcery/outbound-publish/res_pjsip_o-0000001a          0          0          0
sorcery/phoneprov/res_pjsip_phonepro-00000026          0          0          0
sorcery/registration/res_pjsip_outbo-00000028          0          0          0
sorcery/resource_list/res_pjsip_pubs-0000001c          0          0          0
sorcery/subscription_persistence/res-0000001b          0          0          0
sorcery/system/res_pjsip-00000007                      0          0          0
sorcery/transport/res_pjsip-00000013                   0          0          0


-- 
To view, visit https://gerrit.asterisk.org/1957
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idc2e5d3dbab15c825b97c38c028319a0d2315c47
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes