[Asterisk-code-review] pjsip: Add option global/regcontext (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: pjsip:  Add option global/regcontext
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1984/4/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

Line 72: 	char *regcontext = ast_sip_get_regcontext();
This should be uninitialized, just 'char *regcontext;'.  Otherwise it will leak memory every time this function runs.


Line 140: 			struct pbx_find_info q = { .stacklen = 0 };
I missed this before, please add a blank line after the variable declaration.


-- 
To view, visit https://gerrit.asterisk.org/1984
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1530c5b45340625805c057f8ff1fb240a43ea62
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Daniel Journo <dan at keshercommunications.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes