[Asterisk-code-review] Sorcery: Create human friendly serializer names. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has uploaded a new change for review.

  https://gerrit.asterisk.org/1948

Change subject: Sorcery: Create human friendly serializer names.
......................................................................

Sorcery: Create human friendly serializer names.

Sorcery name formats:
sorcery/<type>-<seq> -- Sorcery thread pool serializer

Change-Id: Idc2e5d3dbab15c825b97c38c028319a0d2315c47
---
M main/sorcery.c
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/48/1948/1

diff --git a/main/sorcery.c b/main/sorcery.c
index e78fc5c..2c00b9a 100644
--- a/main/sorcery.c
+++ b/main/sorcery.c
@@ -820,7 +820,8 @@
 {
 #define INITIAL_WIZARD_VECTOR_SIZE 5
 	struct ast_sorcery_object_type *object_type;
-	char uuid[AST_UUID_STR_LEN];
+	char tps_name[AST_TASKPROCESSOR_MAX_NAME + 1];
+	char seq[8 + 1 + 1];
 
 	if (!(object_type = ao2_alloc(sizeof(*object_type), sorcery_object_type_destructor))) {
 		return NULL;
@@ -853,12 +854,12 @@
 		return NULL;
 	}
 
-	if (!ast_uuid_generate_str(uuid, sizeof(uuid))) {
-		ao2_ref(object_type, -1);
-		return NULL;
-	}
+	/* Create name with seq number appended.  Truncate type to ensure string fits. */
+	snprintf(seq, sizeof(seq), "-%08x", ast_taskprocessor_seq_num());
+	snprintf(tps_name, sizeof(tps_name) - sizeof(seq) + 1, "sorcery/%s", type);
+	strcat(tps_name, seq);
 
-	if (!(object_type->serializer = ast_threadpool_serializer(uuid, threadpool))) {
+	if (!(object_type->serializer = ast_threadpool_serializer(tps_name, threadpool))) {
 		ao2_ref(object_type, -1);
 		return NULL;
 	}

-- 
To view, visit https://gerrit.asterisk.org/1948
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idc2e5d3dbab15c825b97c38c028319a0d2315c47
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>