[Asterisk-code-review] include/asterisk/time.h: Renamed global declaration:tv (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: include/asterisk/time.h: Renamed global declaration:tv
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/1923/2/include/asterisk/time.h
File include/asterisk/time.h:

Line 41: extern struct timeval __ast_tv;
> I think a more unique name would be better for this.  Something like:
Actually since this is just an extern, the actual symbol storage isn't defined so it cannot be exported.  That said I agree with you a more unique name like dummy_tv_var_for_types would be better, or maybe fake_tv_var_for_types?  Otherwise maybe the comment should mention that the symbol doesn't actually exist.


-- 
To view, visit https://gerrit.asterisk.org/1923
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a6e17995006584f3627efe8988e3f8aa0f5dc28
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes