[Asterisk-code-review] app queue: Add member flag "in call" to prevent reading wron... (asterisk[master])

[Matt Jordan]

Matt Jordan has posted comments on this change.

Change subject: app_queue: Add member flag "in_call" to prevent reading wrong lastcall time
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1847/3/apps/app_queue.c
File apps/app_queue.c:

Line 997: 		<syntax>
        : 				<parameter name="Queue">
        : 					<para>The name of the queue.</para>
        : 				</parameter>
        : 				<parameter name="MemberName">
        : 					<para>The name of the queue member.</para>
        : 				</parameter>
The new parameter that shows up in QueueMember related events needs to be documented here, i.e., either InCall or IsInCall.


Line 9687: 						"IsInCall: %d\r\n"
The attributes for a QueueMember event should preferably match the attributes placed in the JSON blob created by queue_member_blob_create.

That is: they both should be InCall, or they both should be IsInCall.


-- 
To view, visit https://gerrit.asterisk.org/1847
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1923230cf9859ee51563a8ed420a0628b4d2e500
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Rafael Prado Rocchi <prado at practis.com.br>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes