[Asterisk-code-review] cel/cel radius: Fix wrong pointer. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue Jan 5 06:00:47 CST 2016


Joshua Colp has posted comments on this change.

Change subject: cel/cel_radius: Fix wrong pointer.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/1901/3/cel/cel_radius.c
File cel/cel_radius.c:

Line 98: #define ADD_VENDOR_CODE(x,y) (rc_avpair_add(rh, send, x, y, strlen(y), VENDOR_CODE))
You will need to cast the const away from 'y' in this:

(char *)y for example.

You could also just cast it directly to (void *) as rc_avpair_add wants


Line 179: 	if (!rc_avpair_add(rh, send, PW_USER_NAME, record->channel_name,
Same here.


-- 
To view, visit https://gerrit.asterisk.org/1901
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72889bccd8fde120d47aa659edc0e7e6d4d019f0
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Aaron An <anjb at ti-net.com.cn>
Gerrit-Reviewer: Aaron An <anjb at ti-net.com.cn>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list