[Asterisk-code-review] voicemail: Move app voicemail / res mwi external conflict to... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: voicemail: Move app_voicemail / res_mwi_external conflict to runtime
......................................................................


Patch Set 5: Code-Review+1

(3 comments)

Looks better now.  Just have a minor nit that didn't get fixed in last round:
SKIP -> DECLINE
reference.

https://gerrit.asterisk.org/#/c/1884/5/apps/app_voicemail.c
File apps/app_voicemail.c:

Line 14760: 	/* ast_vm_register may return SKIP if another module registered for vm */
SKIP -> DECLINE


Line 14768: 	/* ast_vm_greeter_register may return SKIP if another module registered as a greeter */
SKIP -> DECLINE


https://gerrit.asterisk.org/#/c/1884/5/res/res_mwi_external.c
File res/res_mwi_external.c:

Line 949: 	/* ast_vm_register may return SKIP if another module registered for vm */
SKIP -> DECLINE


-- 
To view, visit https://gerrit.asterisk.org/1884
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d98d4e8a3b87b8df9e51c2608f0da6ddfb89247
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes