[Asterisk-code-review] cdr/originate-cdr-disposition: Fix ordering of SIP messages ... (testsuite[master])

[Anonymous Coward]

Anonymous Coward #1000019 has submitted this change and it was merged.

Change subject: cdr/originate-cdr-disposition: Fix ordering of SIP messages in scenario
......................................................................


cdr/originate-cdr-disposition: Fix ordering of SIP messages in scenario

The SIPp scenario wait-for-call-timeout attempts to send a 487 to a cancelled
INVITE request before responding to the CANCEL request with a 200 OK. As a
result, on faster machines, Asterisk will send the ACK to the 487 prior to
the SIPp scenario sending the 200 OK. This can cause the scenario to fail,
as it will receive the ACK prior to sending the 200.

This patch reorders the 487/200, as Asterisk will not send an ACK until it
receives the final response for the INVITE request. Overall, this makes the
scenario slightly more reliable.

Change-Id: I955b15b488881835b7dd39b6b34cd35c3fb233fd
---
M tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml
1 file changed, 15 insertions(+), 14 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml b/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml
index 1b1a41e..d34f9e2 100644
--- a/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml
+++ b/tests/cdr/originate-cdr-disposition/sipp/wait-for-call-timeout.xml
@@ -31,20 +31,6 @@
     <send>
         <![CDATA[
 
-        SIP/2.0 487 Request Terminated
-        [last_Via:]
-        [last_From:]
-        [last_To:];tag=[call_number]
-        [last_Call-ID:]
-        CSeq: 102 INVITE
-        Contact: sip:[field0 line="[$line]"]@[local_ip]:[local_port]
-        Content-Length: 0
-
-        ]]>
-    </send>
-    <send>
-        <![CDATA[
-
         SIP/2.0 200 OK
         [last_Via:]
         [last_From:]
@@ -57,5 +43,20 @@
         ]]>
     </send>
 
+    <send>
+        <![CDATA[
+
+        SIP/2.0 487 Request Terminated
+        [last_Via:]
+        [last_From:]
+        [last_To:];tag=[call_number]
+        [last_Call-ID:]
+        CSeq: 102 INVITE
+        Contact: sip:[field0 line="[$line]"]@[local_ip]:[local_port]
+        Content-Length: 0
+
+        ]]>
+    </send>
+
     <recv request="ACK" optional="false" />
 </scenario>

-- 
To view, visit https://gerrit.asterisk.org/1894
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I955b15b488881835b7dd39b6b34cd35c3fb233fd
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>