[Asterisk-code-review] build-system: Allow building with static pjproject (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: build-system: Allow building with static pjproject
......................................................................


Patch Set 24:

As far as the build system stuff is concerned, you get an implicit +1 from me because my brain goes numb when I start looking at that stuff.

What concerns me here is the library of patches. I'm fine with maintaining this sort of directory as long as the patches are

1) Also contributed upstream to PJProject
2) Directly fixing a problem that has been reported in Asterisk.

Some of the patches on this issue appear to conform to what I suggested. Others, I'm not so sure about (e.g. log level patch, no third party patch). I would suggest that any patch that does not conform to the above guidelines should not be included in the Asterisk source. My main concerns are that
1) We may be tempted to go the easy way with certain bug fixes and write a patch for the patch library instead of doing the right thing and contributing upstream.
2) The maintenance task of keeping patches up-to-date when new versions of PJProject are released can snowball more quickly than we would like. Using only patches contributed upstream means we just empty the patch directory with each new PJProject release.

-- 
To view, visit https://gerrit.asterisk.org/2072
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a60c28c2e9ba9537c5570f933c1ebcb20a3103
Gerrit-PatchSet: 24
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No