[Asterisk-code-review] build-system: Allow building with static pjproject (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: build-system: Allow building with static pjproject
......................................................................


Patch Set 22: Code-Review-1

(5 comments)

This one works for me! Yay!

https://gerrit.asterisk.org/#/c/2072/22/CHANGES
File CHANGES:

Line 37:    installation, if any. 
       :  
You need some visine for this redness


https://gerrit.asterisk.org/#/c/2072/22/main/Makefile
File main/Makefile:

Line 309: else	
Such redness!


https://gerrit.asterisk.org/#/c/2072/22/third-party/pjproject/Makefile
File third-party/pjproject/Makefile:

Line 41: 	curl -L $(PJPROJECT_URL)/$(@F) -o $@
If you don't have curl available what happens? Can we fallback on wget?


Line 50: 	$(CMD_PREFIX) cp -f ./patches/config_site.h ./source/pjlib/include/pj/ 
Redness


https://gerrit.asterisk.org/#/c/2072/22/third-party/pjproject/Makefile.rules
File third-party/pjproject/Makefile.rules:

Line 4: PJPROJECT_CONFIG_OPTS = --prefix=/usr/local --with-external-speex --with-external-gsm --with-external-srtp \
I'd rather opt for something really out there "just in case". /opt/pjproject or something


-- 
To view, visit https://gerrit.asterisk.org/2072
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a60c28c2e9ba9537c5570f933c1ebcb20a3103
Gerrit-PatchSet: 22
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes