[Asterisk-code-review] tests/test http media cache: Add unit tests for res http med... (asterisk[master])

[Badalian Vyacheslav]

Badalian Vyacheslav has posted comments on this change.

Change subject: tests/test_http_media_cache: Add unit tests for res_http_media_cache
......................................................................


Patch Set 4:

(5 comments)

https://gerrit.asterisk.org/#/c/1891/4/tests/test_http_media_cache.c
File tests/test_http_media_cache.c:

Line 176: 		if (options.send_file) {
you have internal member sendfile... with some additional check... i don't see where options.send_file may be redefined...


Line 180: 
if (sendfile) {
close(fd); // Becouse if you go to  "sendfile" block upper, you will have FD or you was go to ERROR!
}


Line 184: 
ast_http_send know that it need to free http_header? or there must be ast_free(&http_header)?


Line 194: 
many variants will be there and have "file_name" do not unlink'ed.....


Line 626: 		return -1;
ast_config_destroy?


-- 
To view, visit https://gerrit.asterisk.org/1891
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2db101e307c863857fe416d6f5bf4cace9ac7cf5
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes