[Asterisk-code-review] res pjsip caller id: Anonymize 'From' when caller id present... (asterisk[13])

[George Joseph]

Hello Mark Michelson, Anonymous Coward #1000019, Walter Doekes,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2293

to look at the new patch set (#4).

Change subject: res_pjsip_caller_id: Anonymize 'From' when caller id presentation is prohibited
......................................................................

res_pjsip_caller_id: Anonymize 'From' when caller id presentation is prohibited

Per RFC3325, the 'From' header is now anonymized on outgoing calls when
caller id presentation is prohibited.

TID = trust_id_outbound
PRO = Set(CALLERID(pres)=prohib)
USR = endpoint/from_user
DOM = endpoint/from_domain
PAI = YES(privacy=off), NO(not sent), PRI(privacy=full) (assumes send_pai=yes)

Conditions          |Result
--------------------|----------------------------------------------------
TID PRO USR DOM     |PAI    FROM
--------------------|----------------------------------------------------
Y   Y   abc def.ghi |PRI    "Anonymous" <sip:abc at def.ghi>
Y   Y   abc         |PRI    "Anonymous" <sip:abc at anonymous.invalid>
Y   Y       def.ghi |PRI    "Anonymous" <sip:anonymous at def.ghi>
Y   Y               |PRI    "Anonymous" <sip:anonymous at anonymous.invalid>

Y   N   abc def.ghi |YES    <sip:abc at def.ghi>
Y   N   abc         |YES    <sip:abc@<ip_address>>
Y   N       def.ghi |YES    "Caller Name" <sip:<caller_exten>@def.ghi>
Y   N               |YES    "Caller Name" <sip:<caller_exten>@<ip_address>>

N   Y   abc def.ghi |NO     "Anonymous" <sip:abc at def.ghi>
N   Y   abc         |NO     "Anonymous" <sip:abc at anonymous.invalid>
N   Y       def.ghi |NO     "Anonymous" <sip:anonymous at def.ghi>
N   Y               |NO     "Anonymous" <sip:anonymous at anonymous.invalid>

N   N   abc def.ghi |YES    <sip:abc at def.ghi>
N   N   abc         |YES    <sip:abc@<ip_address>>
N   N       def.ghi |YES    "Caller Name" <sip:<caller_exten>@def.ghi>
N   N               |YES    "Caller Name" <sip:<caller_exten>@<ip_address>>

ASTERISK-25791 #close
Reported-by: Anthony Messina

Change-Id: I2c82a5ca1413c2c00fb62ea95b0ae8e97af54dc9
---
M CHANGES
M include/asterisk/res_pjsip.h
M include/asterisk/res_pjsip_session.h
M res/res_pjsip.c
M res/res_pjsip_caller_id.c
M res/res_pjsip_session.c
6 files changed, 137 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/93/2293/4
-- 
To view, visit https://gerrit.asterisk.org/2293
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c82a5ca1413c2c00fb62ea95b0ae8e97af54dc9
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>