[Asterisk-code-review] sorcery: Fix sorcery wizard create so it creates in caches (asterisk[13])

Joshua Colp asteriskteam at digium.com
Sat Feb 27 16:53:13 CST 2016


Joshua Colp has posted comments on this change.

Change subject: sorcery:  Fix sorcery_wizard_create so it creates in caches
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2312/1/main/sorcery.c
File main/sorcery.c:

Line 1957: 	return (!object_wizard->wizard->callbacks.create(details->sorcery, object_wizard->data, details->obj) &&
My only concern with this is that it will cache even if the object is not persisted in a backend.


-- 
To view, visit https://gerrit.asterisk.org/2312
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5596ce691685a79886e57b0865888458d6e7b46
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list