[Asterisk-code-review] res pjsip caller id: Anonymize 'From' when caller id present... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: res_pjsip_caller_id: Anonymize 'From' when caller id presentation is prohibited
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/2293/1/res/res_pjsip_caller_id.c
File res/res_pjsip_caller_id.c:

Line 696: 	/* We need to add pai/rpid before anonymizing From */
        : 	add_id_headers(session, tdata, &connected_id);
> *Do* we need to do this before?
This is just a code ordering thing.  The code that sets RPID/PAI takes some values from the existing From header.  If we anonymize From first, then RPID/PAI will get anonymous.invalid as the domain which we don't want.


Line 700: 		/* Only change the From header on the initial outbound INVITE. Switching it
        : 		 * mid-call might confuse some UAs.
> Yes, I cannot find this explicit limitation in RFC 3261:
This is existing code I didn't touch.


-- 
To view, visit https://gerrit.asterisk.org/2293
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c82a5ca1413c2c00fb62ea95b0ae8e97af54dc9
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-HasComments: Yes