[Asterisk-code-review] Add initial support to build Docker images (asterisk[13])

[Leif Madsen]

Leif Madsen has posted comments on this change.

Change subject: Add initial support to build Docker images
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.asterisk.org/#/c/2297/1/contrib/docker/Dockerfile.asterisk
File contrib/docker/Dockerfile.asterisk:

Line 8: COPY $RPMPATH/*.rpm $STARTDIR
> I don't understand the benefit of this.  Wouldn't this add the RPM's as an 
This is required because you can't mount a volume during build. You need to copy the RPM into the container in order to install it during the build process. Unfortunately I don't think there is a way around this.


Line 9: RUN yum install epel-release -y
> Why do this separate?  I mean I understand that it needs to be a separate c
Fixed.


https://gerrit.asterisk.org/#/c/2297/1/contrib/docker/Dockerfile.packager
File contrib/docker/Dockerfile.packager:

Line 9: RUN /tmp/install_prereq install
> We should have a 'yum clean all' after running install_prereq.  Any reason 
Fixed. Thanks!


https://gerrit.asterisk.org/#/c/2297/1/contrib/docker/README.md
File contrib/docker/README.md:

Line 23: > you'll need to use the following command instead:
> it looks the same to me.  What am I missing?
Nice catch :)  Forgot to update. Fixed!


-- 
To view, visit https://gerrit.asterisk.org/2297
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa070706d40e56755797097b6ed72c1e243bd0d1
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Leif Madsen <leif at leifmadsen.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Leif Madsen <leif at leifmadsen.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes