[Asterisk-code-review] main/cli.c: Refactor function to print seconds formatted (asterisk[master])

Rodrigo Ramirez Norambuena asteriskteam at digium.com
Thu Feb 18 19:06:42 CST 2016


Rodrigo Ramirez Norambuena has posted comments on this change.

Change subject: main/cli.c: Refactor function to print seconds formatted
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/2272/2/addons/cdr_mysql.c
File addons/cdr_mysql.c:

Line 122: 		char status[256], status2[100] = "", buf[356];
> buf should be on it's own line (even though status and status2 weren't).  A
I'll apply the changes. I think the assignment the buffer to print string could be by other way. Not set a static lenght of char may by ast_str other thing.


-- 
To view, visit https://gerrit.asterisk.org/2272
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb8634102cd11d3f8623398b279cb731bcde36c
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list