[Asterisk-code-review] res pjproject: Add ability to map pjproject log levels to A... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjproject:  Add ability to map pjproject log levels to Asterisk log levels
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2245/3/configs/samples/pjproject.conf.sample
File configs/samples/pjproject.conf.sample:

Line 7: ;  NOTE: The id of this object MUST be log_mappings.
I'd extend this to make it easier for a user to know what this means. Perhaps "The name of this section in the pjproject.conf configuration file must remain log_mappings or the configuration will not be applied".


https://gerrit.asterisk.org/#/c/2245/3/res/res_pjproject.c
File res/res_pjproject.c:

Line 117: 		AST_STRING_FIELD(asterisk_error);
        : 		AST_STRING_FIELD(asterisk_warning);
        : 		AST_STRING_FIELD(asterisk_notice);
        : 		AST_STRING_FIELD(asterisk_verbose);
        : 		AST_STRING_FIELD(asterisk_debug);
It's common to document what these mean in the structure def too.


-- 
To view, visit https://gerrit.asterisk.org/2245
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba7bb349c70397586889b8f45b8c3d6c6c8c3898
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes