[Asterisk-code-review] main/cli.c: Refactor function to print seconds formated (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: main/cli.c: Refactor function to print seconds formated
......................................................................


Patch Set 2: Code-Review-1

(7 comments)

https://gerrit.asterisk.org/#/c/2272/2//COMMIT_MSG
Commit Message:

Line 10: secondsformated
seconds formatted


Line 12: not
now


https://gerrit.asterisk.org/#/c/2272/2/addons/cdr_mysql.c
File addons/cdr_mysql.c:

Line 122: 		char status[256], status2[100] = "", buf[356];
buf should be on it's own line (even though status and status2 weren't).  Also, buf isn't big enough to handle status, status2, and " for ".


https://gerrit.asterisk.org/#/c/2272/2/cdr/cdr_pgsql.c
File cdr/cdr_pgsql.c:

Line 142: 		char status[256], status2[100] = "", buf[356];
Same issue as before


https://gerrit.asterisk.org/#/c/2272/2/include/asterisk/cli.h
File include/asterisk/cli.h:

Line 320: inseconds
in seconds


https://gerrit.asterisk.org/#/c/2272/2/res/res_config_ldap.c
File res/res_config_ldap.c:

Line 1840: 	char status[256], credentials[100] = "", buf[356];
same


https://gerrit.asterisk.org/#/c/2272/2/res/res_config_pgsql.c
File res/res_config_pgsql.c:

Line 1577: 	char connection_info[256], credentials[100] = "", buf[356];
same


-- 
To view, visit https://gerrit.asterisk.org/2272
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibeb8634102cd11d3f8623398b279cb731bcde36c
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes