[Asterisk-code-review] testsuite: Fix tests/fax/pjsip/directmedia reinvite t38 (testsuite[master])

[Richard Mudgett]

Richard Mudgett has uploaded a new change for review.

  https://gerrit.asterisk.org/2271

Change subject: testsuite: Fix tests/fax/pjsip/directmedia_reinvite_t38
......................................................................

testsuite: Fix tests/fax/pjsip/directmedia_reinvite_t38

The test was occasionally failing because of timing.  The endpoint_A SIPp
scenario expects the call to reINVITE media back to Asterisk before
hanging up.  Sometimes the reINVITE doesn't have a chance to get started
before dialplan hangs up the call and a BYE goes out instead.

* Added a Wait to the dialplan to allow the reINVITE to at least get
started before dialplan hangs up the call after endpoint_B hangs up.

* Removed unnecessary dialplan extensions.

* Added missing test dependencies to the test yaml file.

ASTERISK-25582 #close

Change-Id: Ib0b35ca580aaca95ce6732dbf060fd46c634e352
---
M tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/extensions.conf
M tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml
2 files changed, 6 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/71/2271/1

diff --git a/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/extensions.conf b/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/extensions.conf
index a83cef4..ccf385b 100644
--- a/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/extensions.conf
+++ b/tests/fax/pjsip/directmedia_reinvite_t38/configs/ast1/extensions.conf
@@ -1,14 +1,8 @@
-[general]
-PHONE_TO_DIAL=PJSIP/endpoint_B/sip:127.0.0.3
-
 [default]
-exten => bypassbridge,1,NoOp()
-	same => n,Dial(PJSIP/endpoint_B/sip:127.0.0.3,,g)
-	same => n,UserEvent(TestStatus, extension: bypassbridge)
-	same => n,Hangup()
-
-; Dial with no options; use bridge set up based on peer definitions
 exten => basicdial,1,NoOp()
 	same => n,Dial(PJSIP/endpoint_B/sip:127.0.0.3,,g)
 	same => n,UserEvent(TestStatus, extension: basicdial)
+	; Wait to allow Asterisk to re-INVITE media back to itself before
+	; hanging up.
+	same => n,Wait(1)
 	same => n,Hangup()
diff --git a/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml b/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml
index 2a21939..3aec3de 100644
--- a/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml
+++ b/tests/fax/pjsip/directmedia_reinvite_t38/test-config.yaml
@@ -25,7 +25,10 @@
     dependencies:
         - sipp :
             version : 'v3.0'
+        - asterisk : 'app_dial'
+        - asterisk : 'app_userevent'
         - asterisk : 'chan_pjsip'
+        - asterisk : 'res_pjsip'
         - asterisk : 'res_pjsip_t38'
     tags:
         - pjsip

-- 
To view, visit https://gerrit.asterisk.org/2271
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0b35ca580aaca95ce6732dbf060fd46c634e352
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>