[Asterisk-code-review] translate: Re-enables native Packet-Loss Concealment (PLC) f... (asterisk[master])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: translate: Re-enables native Packet-Loss Concealment (PLC) for iLBC and Speex.
......................................................................


Patch Set 6:

I am an external contributor, not an integrator. I do not have a bird’s-eye view on the project. Therefore, I do not know the answer to those questions.

The current maximum limit of sequence numbers is sufficient for my cases (half of 0xffff) and I am not aware of an reason to lower that, because finding gaps is the sole purpose of the RTP sequence number. Or stated differently: I am not aware of any situation with a (normal) gap. The case about a rolling-over sequence number (0xffff -> 0x0000 or even any 0xYYYY) is handled by the code and was tested.

When it comes to the invalid/initial value of sequence numbers. Yes, that might be. However, I am not an integrator and I am able to speak only about my test cases (SIP, RTP). If there are none-RTP cases, please, say so – then, I look at those.

Furthermore, I cannot decide whether ast_translate(.) is the correct place to do this. Or another place like ast_rtp_read(.).

Finally according to the documentation, native PLC did work sometime in the past. As stated in the issue report 25629, I went back several years and releases and was not able to find the code related to this feature. I would be more than happy, if someone could point me to that code. That might provide additional test cases and/or a better architectural solution.

-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: mattf <creslin at digium.com>
Gerrit-HasComments: No