[Asterisk-code-review] stasis bridge: Ensure the test gives time for all events to ... (testsuite[master])

Kevin Harwell asteriskteam at digium.com
Mon Feb 15 11:04:00 CST 2016


Kevin Harwell has posted comments on this change.

Change subject: stasis_bridge: Ensure the test gives time for all events to be received.
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/2215/3/tests/rest_api/external_interaction/bridge_app/x_option/stasis_bridge/test-config.yaml
File tests/rest_api/external_interaction/bridge_app/x_option/stasis_bridge/test-config.yaml:

Line 54:         -
       :             # This channel explicitly waits to give time for all events to be received
       :             channelId: 'wait'
       :             endpoint: 'Local/wait at default'
       :             context: 'default'
       :             extension: 'echo'
       :             priority: '1'
> That's the problem, the events are coming over both AMI and ARI and have no
Sounds like the event action module needs a way to monitor all events and actions and once all events have been met and all actions completed then ends the test.

However, I get that's not the quickest of fixes and what you have here should work so I'll leave it up to you.


-- 
To view, visit https://gerrit.asterisk.org/2215
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf776149b9d0052b0db5be271608f508d2ee97ff
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list