[Asterisk-code-review] stasis bridge: Ensure the test gives time for all events to ... (testsuite[master])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: stasis_bridge: Ensure the test gives time for all events to be received.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/2215/3/tests/rest_api/external_interaction/bridge_app/x_option/stasis_bridge/test-config.yaml
File tests/rest_api/external_interaction/bridge_app/x_option/stasis_bridge/test-config.yaml:

Line 54:         -
       :             # This channel explicitly waits to give time for all events to be received
       :             channelId: 'wait'
       :             endpoint: 'Local/wait at default'
       :             context: 'default'
       :             extension: 'echo'
       :             priority: '1'
> Can you not just set the config option 'stop-on-end' to false here instead?
What will stop the reactor in that case? The fundamental problem is that I need all events to be received before stopping the reactor, which we don't currently have the capacity to do. If I stop on something else then I may miss the other event. I could also just let it time out, but that doesn't seem as clean.


-- 
To view, visit https://gerrit.asterisk.org/2215
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf776149b9d0052b0db5be271608f508d2ee97ff
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes