[Asterisk-code-review] stasis bridge: Hangup from dialplan to give time for Stasis ... (testsuite[master])

Kevin Harwell asteriskteam at digium.com
Fri Feb 12 14:22:37 CST 2016


Kevin Harwell has posted comments on this change.

Change subject: stasis_bridge: Hangup from dialplan to give time for Stasis messages.
......................................................................


Patch Set 1:

The way I understand the EventActionModule to work is it waits for events to be received. Once all matching events are received it stops. Otherwise it should sit there until the test times out.

But I am guessing the AriOriginateTestObject is stopping the test once all iterations have been ran and it is not waiting for the EventActionModule to do its thing.

There looks to be an option 'stop-on-end' (see AriTestObject) that defaults to 'True'. I believe setting this value to 'False' may fix the issue.

I don't understand how the test terminates when it is still waiting on events? Does it timeout? Otherwise there may be a bug in the EventActionModule.

-- 
To view, visit https://gerrit.asterisk.org/2215
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf776149b9d0052b0db5be271608f508d2ee97ff
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list