[Asterisk-code-review] res pjsip: Refactor load module/unload module (asterisk[master])

George Joseph asteriskteam at digium.com
Thu Feb 11 20:07:52 CST 2016


Hello Mark Michelson, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2225

to look at the new patch set (#2).

Change subject: res_pjsip:  Refactor load_module/unload_module
......................................................................

res_pjsip:  Refactor load_module/unload_module

load_module was just too hairy with every step having to clean up all
previous steps on failure.

Some of the pjproject init calls have now been moved to a separate
load_pjsip function and the unload_pjsip function was enhanced to clean
up everything if an error happened at any stage of the load process.

In the process, a bunch of missing pj_shutdowns, serializer_pool_shutdowns
and ast_threadpool_shutdowns were also corrected.

Change-Id: I5eec711b437c35b56605ed99537ebbb30463b302
---
M res/res_pjsip.c
M res/res_pjsip/pjsip_configuration.c
2 files changed, 107 insertions(+), 117 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/25/2225/2
-- 
To view, visit https://gerrit.asterisk.org/2225
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5eec711b437c35b56605ed99537ebbb30463b302
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list