[Asterisk-code-review] stasis bridge: Hangup from dialplan to give time for Stasis ... (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: stasis_bridge: Hangup from dialplan to give time for Stasis messages.
......................................................................


Patch Set 1:

The big problem I have with this is that it is fundamentally changing the nature of the test. Before, the idea was that when Alice and Bob have entered Bridge(), hanging up Bob would ensure that Alice automatically was hung up and that she would not re-enter Stasis. This change makes it so that Alice is actually first to hang up in the bridge since her Wait() will expire first. It no longer tests the thing it was supposed to test.

The problem here is that the EventActionModule is not a very good fit for this situation. You really only want to hang Bob and dummy up once you have received all of ChannelLeftBridge (alice), StasisEnd (alice), and BridgeEnter(bob). The event action module does not easily allow for multiple conditions to be met before taking some action. And since the actions can come out of the expected order, you can't place the hangup action after any one particular event.

-- 
To view, visit https://gerrit.asterisk.org/2215
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf776149b9d0052b0db5be271608f508d2ee97ff
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No