[Asterisk-code-review] build-system: Allow building with static pjproject (asterisk[13])

Joshua Colp asteriskteam at digium.com
Thu Feb 11 14:00:16 CST 2016


Joshua Colp has posted comments on this change.

Change subject: build-system: Allow building with static pjproject
......................................................................


Patch Set 10: Code-Review-1

Just some general comments to mirror our discussion from IRC and so people know where this is:

1. I've run into problems using this on my system, I think we'll need multiple people to try it out and fine-tune stuff
2. The instructions are unclear of exactly what to do to use it
3. If you fail to follow the instructions exactly the resulting error message from configure can be confusing to a non-developer

Something I didn't mention:

1. I think distclean should clean out the third party stuff as well. Right now it doesn't seem to.

-- 
To view, visit https://gerrit.asterisk.org/2072
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7a60c28c2e9ba9537c5570f933c1ebcb20a3103
Gerrit-PatchSet: 10
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list