[Asterisk-code-review] translate: Re-enables native Packet-Loss Concealment (PLC) f... (asterisk[master])

[mattf]

mattf has posted comments on this change.

Change subject: translate: Re-enables native Packet-Loss Concealment (PLC) for iLBC and Speex.
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.asterisk.org/#/c/1820/6/main/file.c
File main/file.c:

Line 450: 	s->fr.seqno = 0x10000;
Does this need to be done in other places of Asterisk that might generate frames with seqno starting at or remaining at 0 (chan_dahdi, other non rtp based channel drivers)?


https://gerrit.asterisk.org/#/c/1820/6/main/translate.c
File main/translate.c:

Line 563: 	}
Should we limit the maximum frames_missing value, in cases where we just have a seqno sequence change or a large seqno gap?


-- 
To view, visit https://gerrit.asterisk.org/1820
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfcf0670e094e9718d82fd9920f1fb2dae122006
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: mattf <creslin at digium.com>
Gerrit-HasComments: Yes