[Asterisk-code-review] res config pgsql: Show error message in reload if not connec... (asterisk[master])

George Joseph asteriskteam at digium.com
Wed Feb 10 11:13:41 CST 2016


George Joseph has posted comments on this change.

Change subject: res_config_pgsql: Show error message in reload if not connected.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2226/2/res/res_config_pgsql.c
File res/res_config_pgsql.c:

Line 1355: ast_log(LOG_ERROR,  "PostgreSQL RealTime: Cannot Connect.\n");
Since you're not actually trying to connect, I think this would be better as

ast_log(LOG_WARNING,  "PostgreSQL RealTime: Not connected\n");


-- 
To view, visit https://gerrit.asterisk.org/2226
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9290115a1aaadb589eb1d02eaeb502eec01b31fa
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list