[Asterisk-code-review] Resources/res phoneprov: fix memory leak and heap-use-after-... (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: Resources/res_phoneprov: fix memory leak and heap-use-after-free
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/2231/1/res/res_phoneprov.c
File res/res_phoneprov.c:

Line 1236: 			var = ast_var_assign(variable_lookup[AST_PHONEPROV_STD_SERVER_PORT], S_OR(value, "5060"));
You could probably simplify this by just cloning value and leaving the rest of the logic untouched.
if (value) {
    value = ast_strdupa(value);
}


-- 
To view, visit https://gerrit.asterisk.org/2231
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3807d3f4726df6864430ec144cf6265d3f538469
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Badalian Vyacheslav <v.badalyan at open-bs.ru>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes