[Asterisk-code-review] res pjsip: Make system and global memory cache friendly (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change.

Change subject: res_pjsip: Make system and global memory_cache friendly
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

Couldn't we document that the usage of a full backend caching for this would be the way to go and forego the naming requirement?

https://gerrit.asterisk.org/#/c/2156/5/res/res_pjsip/config_global.c
File res/res_pjsip/config_global.c:

Line 259: 				ast_log(LOG_NOTICE, "Consider renaming the pjsip '%s' global object to 'global' to enable caching\n", ast_sorcery_object_get_id(cfg));
This gives a false impression that doing this will automatically enable caching, which is not true.


https://gerrit.asterisk.org/#/c/2156/5/res/res_pjsip/config_system.c
File res/res_pjsip/config_system.c:

Line 173: 				ast_log(LOG_NOTICE, "Consider renaming the pjsip '%s' system object to 'system' to enable caching\n", ast_sorcery_object_get_id(cfg));
Same here.


-- 
To view, visit https://gerrit.asterisk.org/2156
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32beaf688449808251b1eb966bb2cfcfc1d08362
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes