[Asterisk-code-review] chan misdn: Fix a few issues causing compile errors (asterisk[11])

George Joseph asteriskteam at digium.com
Fri Feb 5 10:34:43 CST 2016


George Joseph has uploaded a new change for review.

  https://gerrit.asterisk.org/2210

Change subject: chan_misdn: Fix a few issues causing compile errors
......................................................................

chan_misdn: Fix a few issues causing compile errors

Change-Id: I54b48c24d7ca88ed80496fdfd142d08772a7ab98
---
M channels/chan_misdn.c
M channels/misdn_config.c
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/10/2210/1

diff --git a/channels/chan_misdn.c b/channels/chan_misdn.c
index 6cab76b..15383cb 100644
--- a/channels/chan_misdn.c
+++ b/channels/chan_misdn.c
@@ -342,8 +342,8 @@
 	int channel;
 };
 
-#define chan_list_ref(obj, debug) (ao2_t_ref((obj), +1, (debug)), (obj))
-#define chan_list_unref(obj, debug) (ao2_t_ref((obj), -1, (debug)), NULL)
+#define chan_list_ref(obj, debug) ao2_t_ref((obj), +1, (debug))
+#define chan_list_unref(obj, debug) ao2_t_ref((obj), -1, (debug))
 
 /*!
  * \brief Channel call record structure
diff --git a/channels/misdn_config.c b/channels/misdn_config.c
index 32f92c3..291f453 100644
--- a/channels/misdn_config.c
+++ b/channels/misdn_config.c
@@ -698,7 +698,7 @@
 	else if ((elem > MISDN_GEN_FIRST) && (elem < MISDN_GEN_LAST))
 		spec = (struct misdn_cfg_spec *)gen_spec;
 
-	if (!spec || !spec[place].desc)
+	if (!spec || ast_strlen_zero(spec[place].desc))
 		memset(buf, 0, 1);
 	else {
 		ast_copy_string(buf, spec[place].desc, bufsize);

-- 
To view, visit https://gerrit.asterisk.org/2210
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54b48c24d7ca88ed80496fdfd142d08772a7ab98
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>



More information about the asterisk-code-review mailing list