[Asterisk-code-review] Check for OpenSSL defines before trying to use them. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: Check for OpenSSL defines before trying to use them.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/2199/2/configure.ac
File configure.ac:

Line 2284: if test "$PBX_CRYPTO" = "1";
         : then
         : 	AST_EXT_LIB_CHECK([OPENSSL], [ssl], [SSL_connect], [openssl/ssl.h], [-lcrypto])
         : fi
         : 
         : if test "$PBX_OPENSSL" = "1";
         : then
         :         AST_CHECK_OSPTK([4], [0], [0])
         :         AST_EXT_LIB_CHECK([OPENSSL_SRTP], [ssl], [SSL_CTX_set_tlsext_use_srtp], [openssl/ssl.h], [-lcrypto])
         : fi
         : 
         : if test "$PBX_OPENSSL" = "1";
         : then
         : 	AST_EXT_LIB_CHECK([OPENSSL_EC], [ssl], [EC_KEY_new_by_curve_name], [openssl/ec.h], [-lcrypto])
         : fi
         : 
         : if test "$PBX_OPENSSL" = "1";
         : then
         :         AST_C_DECLARE_CHECK([OPENSSL_ECDH_AUTO], [SSL_CTX_set_ecdh_auto], [openssl/ssl.h])
         : fi
         : 
         : if test "$PBX_OPENSSL" = "1";
         : then
         :         AST_C_DEFINE_CHECK([SSL_OP_NO_TLSV1_1], [SSL_OP_NO_TLSv1_1], [openssl/ssl.h])
         :         AST_C_DEFINE_CHECK([SSL_OP_NO_TLSV1_2], [SSL_OP_NO_TLSv1_2], [openssl/ssl.h])
         : fi
Wonder why these aren't in one if block.


-- 
To view, visit https://gerrit.asterisk.org/2199
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a2eb9a43fd0738b404d8f6f2cf4b5c22d9d752d
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes