[Asterisk-code-review] res pjsip: Make system and global memory cache friendly (asterisk[master])

George Joseph asteriskteam at digium.com
Thu Feb 4 16:13:00 CST 2016


Hello Kevin Harwell, Mark Michelson, Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/2157

to look at the new patch set (#2).

Change subject: res_pjsip: Make system and global memory_cache friendly
......................................................................

res_pjsip: Make system and global memory_cache friendly

Since we can't depend on what an admin names their system and global config
sections, we've had to use retrieve_by_fields to get them which isn't
memory_cache friendly.

We now print a notice if the sections aren't named "system" and "global"
respectively informing the admin that renaming them will allow caching and the
"get" functions now retrieve_by_id for the "system" and "global" names first
and only retrieve_by_fields if the exact names aren't found.  The pjsip.conf
sample has also been updated to note this.

Change-Id: I32beaf688449808251b1eb966bb2cfcfc1d08362
---
M configs/samples/pjsip.conf.sample
M res/res_pjsip/config_global.c
M res/res_pjsip/config_system.c
3 files changed, 98 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/57/2157/2
-- 
To view, visit https://gerrit.asterisk.org/2157
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32beaf688449808251b1eb966bb2cfcfc1d08362
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list