[Asterisk-code-review] res pjsip: Make system and global memory cache friendly (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change.

Change subject: res_pjsip: Make system and global memory_cache friendly
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/2156/1/res/res_pjsip/config_system.c
File res/res_pjsip/config_system.c:

Line 137:  * \brief Observer to set default global object if none exist.
missed one :-)

s/global/system


Line 252: 	if (ast_sorcery_instance_observer_add(system_sorcery, &observer_callbacks_system)) {
        : 		return -1;
        : 	}
This needs a corresponding observer remove in the destroy_system function.


-- 
To view, visit https://gerrit.asterisk.org/2156
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32beaf688449808251b1eb966bb2cfcfc1d08362
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes