[Asterisk-code-review] AST-2016-003 udptl.c: Fix uninitialized values. (asterisk[11])

Torrey Searle asteriskteam at digium.com
Thu Feb 4 02:03:53 CST 2016


Torrey Searle has posted comments on this change.

Change subject: AST-2016-003 udptl.c: Fix uninitialized values.
......................................................................


Patch Set 2:

According to the code,

                                        /* valid secondaries can contain zero-length packets that should be ignored */


If I understand the impacts of this patch correctly, then despite 0 length secondary packets being valid, if a 2ndary packet is 0 length, both the primary ifp and the 2ndary will be discarded instead of the 0 length packet being skipped.  Is this actually the desired effect?

-- 
To view, visit https://gerrit.asterisk.org/2177
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97df8375041be986f3f266ac1946a538023a5255
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list