[Asterisk-code-review] build system: Fix some warnings highlighted by clang (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: build_system:  Fix some warnings highlighted by clang
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/2138/3/channels/sig_analog.h
File channels/sig_analog.h:

Line 102: 	ANALOG_SUB_ERROR = -1,
> I don't think adding a -1 value here is a good idea.  The enum value is use
__analog_handle_event in sig_analog.c tries to assign the return of analog_get_index (which returns -1 on error) to the enum.  That's the place it's set for all other uses and it checks for the -1.


-- 
To view, visit https://gerrit.asterisk.org/2138
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5195b6189b148c2ee3ed4a19d015a6d4ef3e77bd
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes