[Asterisk-code-review] build system: Fix some warnings highlighted by clang (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: build_system:  Fix some warnings highlighted by clang
......................................................................


Patch Set 2:

(1 comment)

The comment made to manager.c applies elsewhere in this change.  Up to you if you want to act on it or not.

https://gerrit.asterisk.org/#/c/2138/2/main/manager.c
File main/manager.c:

Line 2337: 		(*user->username ? user->username : "(N/A)"),
user->username is not a pointer so this looks weird.  Could we maybe solve the problem with user->username[0] ? user->username : "(N/A)"?  Or for that matter why not S_OR(user->username, "(N/A)")?


-- 
To view, visit https://gerrit.asterisk.org/2138
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5195b6189b148c2ee3ed4a19d015a6d4ef3e77bd
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes